Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ioss includes own headers with <> #415

Closed
mathstuf opened this issue Oct 30, 2023 · 3 comments
Closed

Ioss includes own headers with <> #415

mathstuf opened this issue Oct 30, 2023 · 3 comments
Assignees
@gsjaardema

Comments

@mathstuf
Copy link
Contributor

This requires that an explicit -I be passed for the headers to find each other. It would be better if the library could include its own headers using "" paths relative to the header itself.
@gsjaardema
Copy link
Member

gsjaardema commented Nov 6, 2023 •
edited
Loading

Yes, that is probably a good idea. At one time, we had a build system where the <> includes were required or strongly recommended, but that is no longer being used and the current includes use a mismash of "" and <>. Would be good to be consistent and probably consistently use ""

@gsjaardema gsjaardema mentioned this issue Nov 20, 2023
Merged
@gsjaardema
Copy link
Member

Does #423 address this issue. It has been merged.

@gsjaardema gsjaardema self-assigned this Nov 28, 2023
@mathstuf
Copy link
Contributor Author

Looks OK to me; I'll be back if we find an issue (next time we bump IOSS). I'll leave you to close according to your workflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gsjaardema gsjaardema

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mathstuf @gsjaardema