Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outdated README #1

Closed
kliegeois opened this issue Jun 27, 2024 · 5 comments
Closed

Outdated README #1

kliegeois opened this issue Jun 27, 2024 · 5 comments

Comments

@kliegeois
Copy link

The README seems outdated:

Kokkos for perfomance portable shared memory parallelism. Genten bundles a clone of the Kokkos source using git subtree for use with inline builds (see below), which is generally kept up to date with the current Kokkos master branch (which corresponds to Kokkos releases). This is the only version of Kokkos that is guaranteed to work with Genten (however later versions or the develop branch may work).
A C++14 standard-compliant compiler. In principle, any C++14 compiler supported by Kokkos should work, (...)

Kokkos latest releases require a C++17 compliant compiler.

An alternative to updating the README to mirror Kokkos compiler requirements every time they changed would be to cite that webpage directly in the README https://kokkos.org/kokkos-core-wiki/requirements.html .

@etphipp
Copy link
Collaborator

etphipp commented Jun 27, 2024

Congratulations on creating the first issue for the new GenTen repo!

The whole README is out of date as most of the build instructions are no longer correct. But this is a good suggestion.

@etphipp
Copy link
Collaborator

etphipp commented Jun 27, 2024

Btw, how did you discover the new repo?

@kliegeois
Copy link
Author

The fact that you made the repo public appeared at the top of my GitHub homepage feed this morning 😃 .

@etphipp
Copy link
Collaborator

etphipp commented Jun 28, 2024

I've updated the README extensively for this and other changes. Have a look if you are so inclined. There is a lot more I need to do in providing actual documentation on how to build and run GenTen.

@kliegeois
Copy link
Author

Thanks for the update!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants