Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem displaying Chinese player name / comments and wrong komi value for sgf exported from Fox Go Server #177

Closed
fuzihang opened this issue Aug 28, 2020 · 9 comments

Comments

@fuzihang
Copy link

fuzihang commented Aug 28, 2020

image
I saved a recent game from fox go server and tried to open it with katrain. This is what happens. Looks like katrain has problems with displaying names and comments. Also it reports wrong komi values.

For reference, this is what it looks like when opened in sabaki.
image

Thanks.

Edit: Here's the sgf.
[伊凌涛]vs[KeJie]1598514385010001105.zip

Edit: Here's some other exported sgfs from foxgo, including 2 Chinese rule games, 2 Japanese rule games and 1 Chinese rule + handicap game.
saves.zip

@sanderland
Copy link
Owner

Could you attach the sgf? (may need to zip it)
I know FoxGo generates incorrect SGFs, with weird handicap settings (HA[1]) instead of komi, and incorrect character-set encoding, so you may want to report this to fox and see if they care to fix. The komi erorr is new to me though.

@fuzihang
Copy link
Author

fuzihang commented Aug 28, 2020

Thanks for the info. I've updated the issue to include the sgf as a zip file. I will try reporting this to Fox if I find a way to do so.

@sanderland
Copy link
Owner

The file actually says KM[375]HA[0] , which is crazy. What is komi supposed to be in this game, 7.5?

@fuzihang
Copy link
Author

fuzihang commented Aug 28, 2020

The file actually says KM[375]HA[0] , which is crazy. What is komi supposed to be in this game, 7.5?

You are right. For this game it should be 7.5. It seems that Fox sgfs have problems with komi. I tried exporting other sgfs from Fox and it never got it correct lol (It is always 375 or 0.0) . It seems that it's necessary to first change the komi in some sgf editor before opening it in katrain so that katago can function correctly.

Leaving alone the komi, is it possible to display the player name / comment correctly in Katrain?

Thanks.

@sanderland
Copy link
Owner

fd67ea8 fixes some of these, specifically the player names and crashes, but it would be nice to have komi correct. If you could make me a table of foxgo settings (rules, handicap, komi) to what the SGF says, I could probably add it.

@fuzihang
Copy link
Author

fuzihang commented Aug 28, 2020

This is the table. I inspected some sgfs (attached as saves.zip in the first post)
exported from foxgo and make this table. However, I'm not sure if this is the general case for Foxgo.
image

@sanderland
Copy link
Owner

well the dayline game has KM[0]HA[2] - so i assume that's a 0.5 komi game.

I think I will ignore komi and assume
HA[0]: 6.5/7.5 depending on rules
HA >= 1 : KM[0,5]

@fuzihang
Copy link
Author

well the dayline game has KM[0]HA[2] - so i assume that's a 0.5 komi game.

I think I will ignore komi and assume
HA[0]: 6.5/7.5 depending on rules
HA >= 1 : KM[0,5]

This makes sense. Thank you for replying swiftly.

@sanderland
Copy link
Owner

probably fixed in 341d016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants