Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types: define BigInt #313

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

types: define BigInt #313

wants to merge 2 commits into from

Conversation

eush77
Copy link

@eush77 eush77 commented Jun 30, 2023

This PR defines BigInt type.

Since it requires ES2020, update ESLint configuration for testing. This triggered comma-dangle in a bunch of places for me, so I fixed those, too.

The actual functional change in index.js does not require ES2020.

eush77 added 2 commits June 30, 2023 17:27
Use es2020 environment and EcmaScript 11 for BigInt type and literals.
Fix `comma-dangle` errors.
@davidchambers
Copy link
Member

Thank you very much for this contribution, @eush77. I'm sorry for taking so long to review it!

I would like to reduce the scope of the changes. If we remove 1n from the test suite, setting env.es2020 to true should suffice. We need not test the literal form given that BigInt (1) evaluates to the same value.

What do you think? I realize that months have passed and you've no doubt moved on to other things. If you'd like to update the pull request yourself, I promise not to leave you hanging again. If you'd prefer for me to make the changes, just say so.

Thanks again for making Sanctuary better. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants