Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

types: document JsSet and JsMap type constructors #282

Merged
merged 1 commit into from
Jan 10, 2020
Merged

types: document JsSet and JsMap type constructors #282

merged 1 commit into from
Jan 10, 2020

Conversation

davidchambers
Copy link
Member

I forgot to include descriptions in #281.

@davidchambers davidchambers requested a review from Avaq January 9, 2020 16:56
Avaq
Avaq approved these changes Jan 10, 2020
View reviewed changes
Copy link
Member

@Avaq Avaq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops! I also forgot to check.

@davidchambers
Copy link
Member Author

When reviewing pull requests one can scrutinize additions; omissions are easily overlooked. 🔍

@davidchambers davidchambers merged commit 820ad20 into master Jan 10, 2020
@davidchambers davidchambers deleted the davidchambers/js-set-map branch January 10, 2020 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Avaq Avaq Avaq approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidchambers @Avaq