allow extractors to return any foldable structure #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidchambers
commented
Apr 3, 2019
| @@ -685,7 +693,7 @@ | |||
| ('Maybe') | |||
| ([]) | |||
| (typeEq ('sanctuary-maybe/Maybe@1')) | |||
| (function(maybe) { return maybe.isJust ? [maybe.value] : []; }); | |||
| (I); | |||
davidchambers
commented
Apr 3, 2019
| [], | ||
| strMap); | ||
| }); | ||
| (I); |
davidchambers
commented
Apr 3, 2019
| @@ -1605,10 +1609,10 @@ | |||
| (t.url) | |||
| (t.supertypes) | |||
| (t._test ([])) | |||
| (t.extractors.$1); | |||
| (t._extractors.$1); | |||
There was a problem hiding this comment.
We provide the user-provided extractor function here to avoid B (toArray) (B (toArray) (_1)).
Avaq
approved these changes
Apr 4, 2019
davidchambers
force-pushed
the
davidchambers/generalize
branch
from
8228f3c to
f8b873e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realized while working on sanctuary-list that we need not require an array of values specifically. Many algebraic data types are foldable, so in some cases the identity function should be able to serve as an extractor function.
I tried generalizing the code to avoid using
toArrayanywhere, but this proved impractical due to uses ofZ.chainwith functions that always return arrays. The solution is to compose each of the extractors withtoArray, necessitating very few internal changes.