Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

types: define NamedRecordType type constructor #238

Merged
merged 1 commit into from
Mar 28, 2019
Merged

types: define NamedRecordType type constructor #238

merged 1 commit into from
Mar 28, 2019

Conversation

davidchambers
Copy link
Member

Closes #138

@davidchambers davidchambers requested review from Avaq and JAForbes March 27, 2019 10:51
@davidchambers davidchambers mentioned this pull request Mar 27, 2019
Merged
Avaq
Avaq approved these changes Mar 28, 2019
View reviewed changes
Copy link
Member

@Avaq Avaq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidchambers davidchambers merged commit 17fe86c into master Mar 28, 2019
@davidchambers davidchambers deleted the davidchambers/record-type branch March 28, 2019 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Avaq Avaq Avaq approved these changes

@JAForbes JAForbes Awaiting requested review from JAForbes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidchambers @Avaq