-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds workflow to trigger nurax deploy on push #5253
Conversation
note that this adds a new use of GitHub Actions. is this something we're open to? |
What is the concern? If GH Actions were to become non-free for public repos in the future? |
i think it's mainly just that it's one more pipeline to configure and monitor, and one more configuration format to manage. i don't have any other github actions projects, so personally i would probably avoid doing maintenance on this. |
For context, the purpose of this is to provide an auto-deploy to the DCE supported I understand that this adds another pipeline, but it reduces manual monitoring. As such, I am in favor of merging this PR. |
@no-reply Are you open to having this merged? |
This issue has been automatically marked as stale because it has not had activity for 30 days. It will be closed if no further activity occurs within 14 days. Thank you for your contributions. |
Discussed today in Tech Call and there are no blockers to this being merged. There was a question about who would maintain this pipeline. There are several folks, including DCE staff, that work with Github Actions. So it seems like there are members of the community that can help maintain this pipeline. It is also worth noting that this is not a critical pipeline. If it fails, it only impacts nurax related deploys. Additionally there are manual steps to deploy that would address the failure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this. It will be nice to have the auto-deploys working.
@samvera/hyrax-code-reviewers