Updating Collection visibility removes edit access for non-admin users in Sirenia

[rjkati]

Descriptive summary

In Hyrax 5.0.1 using sirenia, when I update the visibility of a collection as a non-admin user, my edit access is removed.

Steps to reproduce the behavior in User Interface (UI)

1. Run a local instance of Sirenia using Docker
2. Log in as a non-admin user
3. Navigate to Dashboard -> Collections -> Add New Collection
4. If prompted, select User Collection
5. Fill out required fields and click Save
6. Click the Discovery tab and change the visibility to Public. Click Save Changes.
7. Observe message You do not have sufficient privileges to edit this document and that you do not have option to edit the collection.

Actual behavior (include screenshots if available)

Changing visibility of a collection as a non-admin removes edit access.

Acceptance Criteria/Expected Behavior

Users should retain edit access to collections when changing visibility.

Related work

#6864

[rjkati]

This issue does not occur on dev.nurax or pg.nurax

[rjkati]

On further testing this seems to occur in sirenia whenever a non-admin user makes any edit to a collection. I observed this behavior when adding metadata to a collection, removing a user and adding a banner

[rjkati]

This works while running the valkyrie-fedora-fix branch locally. I can successfully create a collection and modify it as a non-admin user without seeing an error message or getting my privileges revoked. I changed the collection visibility, updated the metadata, and added a banner