Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ValkyrieCharacterizationService should publish file.characterized #6162

Closed
hackartisan opened this issue Aug 22, 2023 · 0 comments · Fixed by #6180
Closed

ValkyrieCharacterizationService should publish file.characterized #6162

hackartisan opened this issue Aug 22, 2023 · 0 comments · Fixed by #6180
Assignees

Comments

@hackartisan
Copy link
Contributor

Descriptive summary

Currently, the ValkyrieIngestJob enqueues the derivatives job directly, and enqueues the characterization job via an object.file.uploaded event.

Instead, ValkyrieIngestJob should not enqueue ValkyrieCreateDerivativesJob. ValkyrieCharacterizationService should publish file.characterized and FileMetadataListener should enqueue either CreateDerivativesJob or ValkyrieCreateDerivativesJob depending on the payload's type.

See

Acceptance Criteria/Expected Behavior

This is a code refactor, but may fix race condition bugs if any exist when derivatives try to run before characterization is finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging a pull request may close this issue.

2 participants