NoMethodError errors for <GenericWork> when adding work to two collections of same single membership type (nurax-pg)

[elrayle]

Descriptive summary

Adding a work to two collections of the same single membership type raises NoMethodError - undefined method 'errors' for <GenericWork>

Expected behavior

When attempting to add a work to a second collection of the same single membership type, after clicking Save, should stay in the editor and see flash message explaining why this is not allowed.

Actual behavior

When attempting to add a work to a second collection of the same single membership type, after clicking Save, it attempts to stay in the editor but raises an exception...

Steps to reproduce the behavior

On nurax-pg...

Prerequisite:

1. Create a collection type that is single membership
2. Create two collections of that type

To Reproduce:

1. Dashboard -> Works -> Add new work -> select any work type
2. Fill in required metadata
3. Select tab: Relationships
4. In Add to collection selection, type name of first single membership collection and click button: Add
5. In Add to collection selection, type name of second single membership collection and click button: Add
6. Click button: Save changes

See exception shown in Actual behavior.

Related work

Issue #5582

[gamontoya]

This appears to be working on Koppie. I'm not sure if seeing two errors reported to the user is expected behavior, however.

[blancoj]

@gamontoya The issue you were seeing on Koppie, I also saw and @cjcolvar helped me resolve it. It is happening because you need the latest version of rails running on Koppie. This is how you get the latest rails installed on Koppie:

docker exec -it koppie-app-1 /bin/sh
bundle update rails

The double error, is what I also saw. I think this is expected behavior, but it would be good to get someone else to confirm that.

[gamontoya]

@blancoj I'll update and try again on koppie, thank you.

@jlhardes This is a fail on nurax-pg:

[gamontoya]

@blancoj I'm seeing the same double error banner even after updating rails on koppie (Rails 7.0.4)

@jlhardes This passes on koppie.

[jlhardes]

Verified that this is still producing the same error message on nurax-pg. It is also still working but still showing 2 flash error messages on koppie. Reopening and moving to In Progress column on project board for follow-up.

[alishaevn]

instructions on how to create a "single membership" collection can be found on hyrax#4011 under the "Steps to reproduce the behavior" heading in the initial comment.

[alishaevn]

@dlpierce which error message do we want to remove?

the error message above the form is created by #after_update_error and rendered by _flash_msg.html.erb.

the error message within the form is created by #full_collections_errors and rendered by _form.html.erb

hyrax	koppie

[dlpierce]

I'm inclined to keep the one rendered by _flash_msg.html.erb, but having it be blank is not ideal.

[alishaevn]

I'm inclined to keep the one rendered by _flash_msg.html.erb, but having it be blank is not ideal.

@dlpierce agreed. idk why the messages are different between the two, but would you like me to move forward with removing the error message within the form? while I'm at it, should I also remove the entire errors block from the form since the flash msg also handles errors on this page?

[gamontoya]

@alishaevn

This is the behavior I'm seeing on nurax-pg Hyrax Version: 4.0.0

[gamontoya]

@alishaevn And this is the behavior on Koppie v4.0.0

[alishaevn]

@gamontoya can you check nurax again? the commit sha listed next to the hyrax revision in the footer is the one for the pr related to this work. looks like it was updated yesterday, but I'm unsure if it was before or after you tested. I don't have a login to check for myself either.

if it doesn't work for you on nurax, can you try locally?

local hyrax

nurax commit sha

[gamontoya]

@alishaevn Yes, I'm on it!

[gamontoya]

@alishaevn This is the latest version of https://pg.nurax.samvera.org/

FWIW: I'm getting the same results as yesterday.

• Works on Koppie
  • commit e5024c6 (HEAD -> main, origin/main, origin/HEAD)
  • Merge: b28d8ff a71eb70
  • Author: Alisha Evans [email protected]
  • Date: Fri Jun 9 16:21:20 2023 -0500
• Does not work on pg-nurax

[gamontoya]

My local environment is upated:
* main 014fe61dc [origin/main] Merge pull request #6090 from samvera/5575-item-actions-edit

Same behavior for Koppie (it works), unlike pg-nurax

[alishaevn]

@gamontoya did your local version of hyrax work? I don't have a login for the pg nurax site so I can't do any debugging there.

[alishaevn]

samvera slack message: https://samvera.slack.com/archives/CB69H0SHM/p1686857592249439

[alishaevn]

I created a login for pg nurax and tested this. I got the same problem. from the screenshot above, and my testing, it appears that the works created on pg nurax are considered to be valkyrie works instead of active fedora ones. when I test the hyrax app locally, the works are active fedora backed. I'm unsure why the mixup is happening on nurax.

@dlpierce any ideas what's causing this inconsistency?

# error from pg
...
hyrax (014fe61dcb0a) app/controllers/concerns/hyrax/works_controller_behavior.rb:203:in `update_valkyrie_work'
hyrax (014fe61dcb0a) app/controllers/concerns/hyrax/works_controller_behavior.rb:104:in `update' 
...


____________________________

# code the above error is referencing
def update
  case curation_concern
  when ActiveFedora::Base
    # this code gets run locally for hyrax
    actor.update(actor_environment) ? after_update_response : after_update_error(curation_concern.errors)
  else
    # this code gets run in pg for hyrax
    update_valkyrie_work
  end
end

[alishaevn]

as info, I created two collections as "single membership" on https://dev.nurax.samvera.org and it didn't error at all. I'm not an admin, so I can't see how the collection type is truly configured. I was just going by the name. feels like it is not configured correctly though.

[gamontoya]

@alishaevn Hi again!

Here's the results from 4 different environments.

dev-nurax (works)

• QA Testing for Hyrax
• Hyrax Version: 4.0.0
• Hyrax Branch: refs/heads/main
• Hyrax Revision: 8aa6379a690945148dbb44e518a0037d370a35e1

pg-nurax (fails)

• QA Testing for Hyrax
• Hyrax Version: 4.0.0
• Hyrax Branch: refs/heads/main
• Hyrax Revision: 014fe61dcb0a92f83bbe0b1b2c0828147ec4b4f8

Local Hyrax (works)

Local Koppie (works)

[alishaevn]

I went to the hyrax working group standup and mentioned the above issue. pg.nurax.samvera.org IS equivalent to local koppie, while dev.nurax.samvera.org is equivalent to dassie.

either way, since the code is working locally for both gabriela and I, daniel wondered if it could be something up with the nurax pg branch that deploys to pg.nurax? maybe a gem is out of date or something?

potentially unrelated, but at this moment, the pg branch is 171 commits ahead and 442 commits behind the main branch. daniel mentioned that there doesn't appear to be any attempt to keep them in line.

[alishaevn]

tldr: I paired with @orangewolf to get the pg app running locally and I can now duplicate the issue in the nurax app. ActiveModel::DeprecationHandlingMessageArray is not defined in the pg app, for some reason, while it is in hyrax.

local koppie

local nurax

[alishaevn]

ActiveModel::DeprecationHandlingMessageArray is not available in rails v6.0.6, which is the version that the nurax pg branch has in its gemfile.lock. the class IS available in rails v6.1.0, which is what the koppie app is using. (koppie is on v6.1.7.3 to be exact)

I changed the gemfile on the nurax pg branch to gem 'rails', '~> 6.0' (what's in koppie) and gem 'rails', '~> 6.1', and ran bundle update rails --conservative. both times I got a "Bundler attempted to update rails but its version stayed the same" message.
I even deleted the gemfile.lock file completely and ran bundle. it says "Bundle complete! 47 Gemfile dependencies, 326 gems now installed.", but the gemfile.lock file is still deleted in my source control, so it doesn't appear to have actually done anything.

[alishaevn]

started a thread in the samvera nurax channel about the above issue.

[alishaevn]

@gamontoya my pr's against the pg app were deployed to pg nurax so this code is ready to be tested again! 🎉

[gamontoya]

@alishaevn I certainly appreciate your persistence--thank you!

@rjkati This ticket is now closeable. Issue resolved for pg-nurax:

• QA Testing for Hyrax
• Hyrax Version: 4.0.0
• Hyrax Branch: refs/heads/main
• Hyrax Revision: eaf5a1f95d1d3905fbb60f5f10ca3a52c630c0a7