Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow AttachFilesToWorkWithOrderedMembersJob to receive either an ActiveFedora object or a Valkyrie resource #4201

Closed
randalldfloyd opened this issue Jan 22, 2020 · 1 comment
Labels

Comments

@randalldfloyd
Copy link
Contributor

Descriptive summary

Convert AttachFilesToWorkWithOrderedMembersJob to allow it to receive either an ActiveFedora based object or a Valkyrie::Resource equivalent object.

Rationale

Allow jobs to execute correctly with existing AF implementation or the Wings Valkyrie implementation.

Expected behavior

AttachFilesToWorkWithOrderedMembersJob receives a Valkyrie::Resource and performs the action.

Actual behavior

AttachFilesToWorkWithOrderedMembersJob raises an exception when passed a Valkyrie::Resource.

Approach for Conversion

See Pattern for Jobs Receiving Parameter that may be an AF Object or a Valkyrie Resource

Related work

These have all be modified to support AF object or Valkyrie resource using the [established pattern]((https://docs.google.com/document/d/1f9yDjtkXapFf1DYLyPhprnB4CPGaZw9p_k8T_tcor-U/edit#heading=h.qt9rxydfd727).

@no-reply
Copy link
Contributor

this is only called from the Actor Stack (CreateWithFilesOrderedMembersActor), so i think it can be closed as wont-fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants