Process RevokeEditJob with either an AF object or a Valkyrie resource based on use_valkyrie parameter

[elrayle]

Descriptive summary

Add use_valkyrie parameter to RevokeEditJob #perform method. When true, use Valkyrie to get the file set object and set permissions on the valkyrie resource. Otherwise, continue to process the ActiveFedora fileset.

Rationale

Allow jobs to execute correctly with existing AF implementation or the wings Valkyrie implementation.

Expected behavior

RevokeEditJob #perform method receives parameters file_set_id, user_key, use_valkyrie: true | false, finding a valkyrie resource when use_valkyrie is true or an AF object if use_valkyrie is false, and in both cases correctly revokes edit from the user for the fileset. Parameter use_valkyrie defaults to : Hyrax.config.use_valkyrie?

To find a fileset by id for a resource, use...

id = Valkyrie::ID.new(file_set_id)
file_set_resource = Hyrax.query_service.find_by(id: file_set_id)

The process for setting the edit access is the same for both types of objects.

To save a fileset resource, use...

Hyrax.persister.save(resource: file_set_resource)

Actual behavior

RevokeEditJob #perform method raises an exception (e.g. Unknown Argument) when use_valkyrie parameter is passed in.

Approach for Conversion

See Pattern for Jobs Receiving Parameter that may be an AF Object or a Valkyrie Resource

Steps to reproduce the behavior

1. Need to add tests that validate that the same tests pass whether a Valkyrie::Resource or an AF object is passed.

See example of processing both objects in... file_set_actor_spec.rb

For testing this job, you can use something like...

RSpec.describe RevokeEditJob do
  [true, false].each do |use_valkyrie|
    context "when use_valkyrie is #{use_valkyrie}" do
      ...
          described_class.perform_now(file_set.id, depositor.user_key, use_valkyrie: use_valkyrie)

Related work

• Issue Process GrantReadJob with either an AF object or a Valkyrie resource based on use_valkyrie parameter #4105 Process GrantReadJob with either an AF object or a Valkyrie resource based on use_valkyrie parameter
• Issue Process GrantEditJob with either an AF object or a Valkyrie resource based on use_valkyrie parameter #4104 Process GrantEditJob with either an AF object or a Valkyrie resource based on use_valkyrie parameter
• Issue Allow GrantEditToMembersJob to receive either an AF object or a Valkyrie resource as the Work #4101 Allow GrantEditToMembersJob to receive either an AF object or a Valkyrie resource as the Work
• Issue Allow GrantReadToMembersJob to receive either an AF object or a Valkyrie resource as the Work #4102 Allow GrantReadToMembersJob to receive either an AF object or a Valkyrie resource as the Work
• Issue Allow RevokeEditToMembersJob to receive either an AF object or a Valkyrie resource as the Work #4103 Allow RevokeReadToMembersJob to receive either an AF object or a Valkyrie resource as the Work
• Issue Allow CharacterizeJob to receive either an AF object or a Valkyrie resource as the FileSet #4100 Allow CharacterizeJob to receive either an AF object or a Valkyrie resource as the FileSet
• Issue Add GlobalID::Identification for resources passed to jobs #4099 Add GlobalID::Identification for resources passed to jobs

[elrayle]

Fixed by PR #4123