From ee5d878583c2ecdb961ee3b6470f70fb00eab632 Mon Sep 17 00:00:00 2001 From: Jeremy Friesen Date: Mon, 11 Dec 2023 12:38:28 -0500 Subject: [PATCH 1/2] =?UTF-8?q?=F0=9F=90=9B=20Fix=20#work=5Fidentifier=5Fs?= =?UTF-8?q?earch=5Ffield=20logic?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The chaining logic for was grabbing the first letter of a single search_field value; instead of grabbing the first value in the 'search_field' object. To fix the problem, we cast the value of `search_field` into an array and then grab the first array element. Related to: - https://github.com/samvera/bulkrax/issues/890 --- app/parsers/bulkrax/application_parser.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/parsers/bulkrax/application_parser.rb b/app/parsers/bulkrax/application_parser.rb index 3cc390ea..bbf57e7b 100644 --- a/app/parsers/bulkrax/application_parser.rb +++ b/app/parsers/bulkrax/application_parser.rb @@ -85,7 +85,7 @@ def work_identifier # defaults to work_identifier value + "_sim" # @see #work_identifier def work_identifier_search_field - @work_identifier_search_field ||= get_field_mapping_hash_for('source_identifier')&.values&.first&.[]('search_field')&.first&.to_s || "#{work_identifier}_sim" + @work_identifier_search_field ||= Array.wrap(get_field_mapping_hash_for('source_identifier')&.values&.first&.[]('search_field'))&.first&.to_s || "#{work_identifier}_sim" end # @return [String] From 90cbae366336eb03f436091e6d0b49eab64c3cba Mon Sep 17 00:00:00 2001 From: Jeremy Friesen Date: Mon, 11 Dec 2023 14:34:38 -0500 Subject: [PATCH 2/2] =?UTF-8?q?=F0=9F=A7=B9=20Appease=20rubocop?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- app/parsers/bulkrax/application_parser.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/parsers/bulkrax/application_parser.rb b/app/parsers/bulkrax/application_parser.rb index bbf57e7b..2a46d124 100644 --- a/app/parsers/bulkrax/application_parser.rb +++ b/app/parsers/bulkrax/application_parser.rb @@ -102,7 +102,7 @@ def related_parents_raw_mapping # @return [String] # @see #related_parents_field_mapping def related_parents_parsed_mapping - @related_parents_parsed_mapping ||= (get_field_mapping_hash_for('related_parents_field_mapping')&.keys&.first || 'parents') + @related_parents_parsed_mapping ||= get_field_mapping_hash_for('related_parents_field_mapping')&.keys&.first || 'parents' end # @return [String, NilClass] @@ -114,7 +114,7 @@ def related_children_raw_mapping # @return [String] # @see #related_children_raw_mapping def related_children_parsed_mapping - @related_children_parsed_mapping ||= (get_field_mapping_hash_for('related_children_field_mapping')&.keys&.first || 'children') + @related_children_parsed_mapping ||= get_field_mapping_hash_for('related_children_field_mapping')&.keys&.first || 'children' end # @api private