Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ObjectFactory#permitted_attributes is missing :admin_set_id #271

Open
aploshay opened this issue Mar 4, 2021 · 1 comment
Open

ObjectFactory#permitted_attributes is missing :admin_set_id #271

aploshay opened this issue Mar 4, 2021 · 1 comment

Comments

@aploshay
Copy link
Contributor

aploshay commented Mar 4, 2021

The Importer form fields include admin_set_id, but this is not passed along in #permitted_attributes, ignoring the AdminSet chosen in the form and causing a created Work to resort to the default AdminSet:
https://github.com/samvera-labs/bulkrax/blob/master/app/factories/bulkrax/object_factory.rb#L226

Adding admin_set_id to the specified array of values resolves the issue.
@aploshay aploshay mentioned this issue Mar 4, 2021
Merged
@alishaevn
Copy link
Contributor

need to see if this is still an issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aploshay @alishaevn