Shutdown the pretender server on destroyApp. #281
Conversation
|
My PR for the destroy-app helper is here |
| 'to see how to fix the problem.' + EOL + | ||
| '******************************************************' + EOL | ||
| ) | ||
| ); |
There was a problem hiding this comment.
I wanted to make sure that people saw this. Without the callout *s it was easy to miss. This is how it looked on my machine:
|
Wow man, you are seriously awesome. Just a thought - if a newbie installs Mirage for the first time and they're hit with that message, it could be a bit disconcerting. Is there anywhere else we could put the message, perhaps as tests are being run, in the console or build output somewhere? |
|
@blimmer what do you think? I'd love to see this merged |
|
Hey @samselikoff I'm really sorry for the silence on this - I must've missed the messages. I worry a bit about burying the message behind test/build output because when the testem runner comes up, it will hide the message, making it super easy to miss. They also need to place the file and then re-run the initializer so the server is shut down correctly. Another strategy we could take would be to not message them and place it in documentation and hope that ember-cli has a release soon. I also rebased this to make it easier to merge. I've got my notification fixed up, so sorry again about the silence. |
blimmer
force-pushed
the
shutdown-server-on-destroy-app
branch
from
217cf04 to
d7d1f6d
Compare
|
This will also not be an issue for people on up-to-date versions of Ember-CLI now that the associated PR there has been merged and released. |
|
Okay, great. So, the message shows once on install, if users are on older versions of Ember CLI, correct? But on newer versions we'll be able to do this transparently? |
|
That's correct! Once on install for older versions of ember-cli. Newer versions should not show the message. |
|
Ok great! Is this rebased off latest master? It's not letting me merge. (Sorry about the delays, as soon as you rebase I'll merge this in - in fact, you can). |
Ember-CLI 1.13.9 and beyond will have a destroy-app helper that we can shutdown the server in. This patch automatically inserts this behavior, or shows a message if the user doesn't have a destroy-app helper explaining how to fix the problem. Fixes miragejs#226.
blimmer
force-pushed
the
shutdown-server-on-destroy-app
branch
from
d7d1f6d to
2d48d7e
Compare
|
Sounds good - this is now rebased. I also updated the changelog so people know that they need to run the addon blueprint when upgrading. |
Shutdown the pretender server on destroyApp.
|
Thank you, great work!
|
Ember-CLI 1.13.9 and beyond will have a destroy-app helper that we can shutdown the server in.
This patch automatically inserts this behavior, or shows a message if the user doesn't have a destroy-app helper explaining how to fix the problem.
Fixes #226.