Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include shared vehicles in getAccountVehicles #241

Merged
merged 2 commits into from
Jan 19, 2024
Merged

Include shared vehicles in getAccountVehicles #241

merged 2 commits into from
Jan 19, 2024

Conversation

FieryFlames
Copy link
Contributor

Fixes #204.
I also removed a random space from includeEntitlements.
This should be tested on a account with no shared vehicles.

@samrum
Copy link
Owner

samrum commented Jan 18, 2024

@BigThunderSR could you test this change?

@BigThunderSR
Copy link
Contributor

@BigThunderSR could you test this change?

Will take a look and see.

@BigThunderSR
Copy link
Contributor

@samrum, this does appear to be working.

  • Tested with my account which is primary and has both vehicles - works.
  • Tested with my wife's account which I have shared both vehicles to - works. (Note: This did not work prior to this code change)

@samrum samrum merged commit 09a173c into samrum:master Jan 19, 2024
3 checks passed
@samrum
Copy link
Owner

samrum commented Jan 19, 2024

Thanks @BigThunderSR and @FieryFlames !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error 500
3 participants
@FieryFlames @samrum @BigThunderSR