Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

timezone information missing in database #96

Open
zerobuzz opened this issue Jun 8, 2014 · 1 comment
Open

timezone information missing in database #96

zerobuzz opened this issue Jun 8, 2014 · 1 comment
Labels
in consideration Describes a feature worth taking into account

Comments

@zerobuzz
Copy link

zerobuzz commented Jun 8, 2014

hi,

i am often switching time zones when using timetrap, and i am painfully missing timezone information in the entries table. i propose to append the name of the local time zone to every datatime in the database, or, if no name is available, the +nnnn time zone spelling.

this would allow old databases to remain valid despite the fact that they do not keep track of timetrap release information. it would be possible to convert old to new databases heuristically setting a default time zone (users should probably get a warning before that happens).

with this change, it would be possible to work on planes on laptops that change local time based on the gps signal without timetrap getting confused. (-:

thanks! great tool!

@zerobuzz zerobuzz changed the title timezone information timezone information missing in database Jun 8, 2014
@samg
Copy link
Owner

samg commented Jun 10, 2014

I think this is a great idea. I'd suggest that timetrap should probably always store time in utc and then present it in the local timezone, though you're correct that this could cause some backwards compatibility problems. From some very light research it looks like sqlite's datetime column doesn't support timezones so we'd need to standardize on one TZ (i.e. UTC) and convert on display. It's probably unlikely that I'll be able to work on this in the short term, though I'd happily review pull requests to add timezone support.

@categulario categulario added the in consideration Describes a feature worth taking into account label May 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in consideration Describes a feature worth taking into account
Projects
None yet
Development

No branches or pull requests

2 participants