From b83064da0005ca055fc15ee478cf064bf91702a4 Mon Sep 17 00:00:00 2001 From: Kit PANG Date: Mon, 9 Oct 2023 09:34:05 +0800 Subject: [PATCH] Fix error when scrolling dropdown with scrollbar (#5839) * Fix error when scrolling dropdown with scrollbar * added comment * add changeset --------- Co-authored-by: Abubakar Abid Co-authored-by: gradio-pr-bot --- .changeset/dry-comics-lick.md | 6 ++++++ js/dropdown/shared/Dropdown.svelte | 5 +++++ 2 files changed, 11 insertions(+) create mode 100644 .changeset/dry-comics-lick.md diff --git a/.changeset/dry-comics-lick.md b/.changeset/dry-comics-lick.md new file mode 100644 index 0000000000000..f106e9c958b22 --- /dev/null +++ b/.changeset/dry-comics-lick.md @@ -0,0 +1,6 @@ +--- +"@gradio/dropdown": patch +"gradio": patch +--- + +fix:Fix error when scrolling dropdown with scrollbar diff --git a/js/dropdown/shared/Dropdown.svelte b/js/dropdown/shared/Dropdown.svelte index c770762eb5d71..ccd307ecf1499 100644 --- a/js/dropdown/shared/Dropdown.svelte +++ b/js/dropdown/shared/Dropdown.svelte @@ -117,6 +117,11 @@ function handle_option_selected(e: any): void { selected_index = parseInt(e.detail.target.dataset.index); + if (isNaN(selected_index)) { + // This is the case when the user clicks on the scrollbar + selected_index = null; + return; + } show_options = false; active_index = null; filter_input.blur();