Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sambacc: extend rados pseudo-uris to include getting mon config keys #97

Merged

Conversation

phlogistonjohn
Copy link
Collaborator

There are cases where certain configuration items may not be stored in the Ceph cluster's rados pool but rather in the Ceph MON's configuration key store. This can be accessed via a mon command. Add support for new pseudo uri's formed like:
rados:mon-config-key:foo/bar/baz

Instead of fetching an item from a rados pool, this will try to fetch a key in a manner equivalent to running the following CLI command:
ceph config-key get foo/bar/baz

This idea is borrowed from the ceph iscsi support.

There are cases where certain configuration items may not be stored in
the Ceph cluster's  rados pool but rather in the Ceph MON's
configuration key store. This can be accessed via a mon command. Add
support for new pseudo uri's formed like:
  rados:mon-config-key:foo/bar/baz

Instead of fetching an item from a rados pool, this will try to fetch a
key in a manner equivalent to running the following CLI command:
  `ceph config-key get foo/bar/baz`

This idea is borrowed from the ceph iscsi support.

Signed-off-by: John Mulligan <[email protected]>
@phlogistonjohn phlogistonjohn added the do-not-merge Hold on label Dec 7, 2023
@phlogistonjohn
Copy link
Collaborator Author

I will clear the DNM label once I have done a 2nd round of "clean" testing on a real ceph cluster.

sambacc/rados_opener.py Show resolved Hide resolved
sambacc/rados_opener.py Show resolved Hide resolved
Copy link
Collaborator

@synarete synarete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mergify mergify bot merged commit 736833f into samba-in-kubernetes:master Dec 13, 2023
9 checks passed
@phlogistonjohn phlogistonjohn deleted the jjm-rados-mon-cfg-key branch December 15, 2023 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants