Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: be clearer about what types top-level configs take #89

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

phlogistonjohn
Copy link
Collaborator

Just clarify what types each configuration section key expects.

@phlogistonjohn
Copy link
Collaborator Author

@Mergifyio rebase

@mergify
Copy link

mergify bot commented Sep 18, 2023

rebase

✅ Branch has been successfully rebased

@anoopcs9
Copy link
Collaborator

@Mergifyio rebase

@mergify
Copy link

mergify bot commented Sep 20, 2023

rebase

✅ Branch has been successfully rebased

Copy link
Collaborator

@synarete synarete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit 7622bc0 into samba-in-kubernetes:master Sep 20, 2023
9 checks passed
@phlogistonjohn phlogistonjohn deleted the jjm-doc-configs branch June 13, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants