-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more distros to CI test runs #76
Add more distros to CI test runs #76
Conversation
8804f87
to
6b29296
Compare
🎉 All dependencies have been resolved ! |
@Mergifyio rebase |
A recent previous change added building RPMs to the container's default set of actions. Add new test runs to exercise all this on various base distros. Signed-off-by: John Mulligan <[email protected]>
Push already only runs on "push" but make it even safer by requiring the "test" job to complete successfully first. Signed-off-by: John Mulligan <[email protected]>
✅ Branch has been successfully rebased |
6b29296
to
d30c0c8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
We'll have to anyway update base image version from 36 to 37 in a month or so with upcoming Fedora 38 release. I think your intention here is to have updated(and compatible) python3-jsonschema package for sambacc. Do we have it in Fedora 37? |
The intent with this PR is to get in the habit of testing on multiple base OS images/versions. Eventually we'll move to fc37 as our default and that will bring with it a distro provided working version of python3-jsonschema, but that's not strictly what this PR is about. I haven't even checked what centos/EPEL has for jsonschema yet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@Mergifyio refresh |
✅ Pull request refreshed |
Depends on: #74
Adds additional test runs using centos stream 9 and fedora 37 base images.
Also adds a change not to run 'push' job unless 'test' succeeds