-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to CentOS Stream 9 as base image #60
Switch to CentOS Stream 9 as base image #60
Conversation
@anoopcs9 - why "do-not-merge"? |
Seems pretty reasonable. My main concern is that with the change in base os we're changing the versions of python that get used for running the tests. That said we can probably take this and iterate from that point... either getting py3.10 (or up) on centos stream 9 or making the containerfile flexible to run on either a fedora or centos base. Therefore I'm leaning on taking this and then tweaking it but let me meditate on a little bit before approving. |
@Mergifyio rebase |
Signed-off-by: Anoop C S <[email protected]>
To get the future behavior now, you can configure Or you can create a dedicated github account for squash and rebase operations, and use it in different |
✅ Branch has been successfully rebased |
22faf7a
to
278f6f8
Compare
FWIW, I was working on something else and wanted to try f37 instead of f36. My workaround for the build process was to disable the rpm install and use the python wheel - which doesn't care about the python abi version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I think I will want to make this work on multiple base distros but that can be done later. Thanks!
@anoopcs9 apologies: I merged despite the do-not-merge label because @phlogistonjohn has approved.... what now? why has mergify not kicked in? |
Actually I had something else in mind while setting the |
Mergify didn't kick in because not all the conditions were met. It would have ignored Anoop's do-not-merge label because of a typo. But it still would not have merged because the rule, summarized in english is: I was going to follow up on the miantainers thing later this week. |
No description provided.