Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use newly replaced leader admin command for ctdb #50

Merged

Conversation

anoopcs9
Copy link
Collaborator

@anoopcs9 anoopcs9 commented Sep 16, 2022

With Samba v4.16, recmaster administrative sub-command for ctdb was renamed to leader. Therefore we make use of already existing mechanism to detect the presence of leader admin command and execute it for determining the leader node.

Copy link
Collaborator

@phlogistonjohn phlogistonjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@phlogistonjohn phlogistonjohn merged commit b4d2532 into samba-in-kubernetes:master Sep 20, 2022
@anoopcs9 anoopcs9 deleted the new-ctdb-admin-cmd branch September 20, 2022 14:45
anoopcs9 added a commit to anoopcs9/samba-container that referenced this pull request Sep 20, 2022
Use the detection mechanism from sambacc[1] via SAMBA_SPECIFICS env
variable to indicate the presence of new/replaced administrative
sub-command 'leader'.

[1] samba-in-kubernetes/sambacc#50

Signed-off-by: Anoop C S <[email protected]>
anoopcs9 added a commit to anoopcs9/samba-container that referenced this pull request Sep 20, 2022
Use the detection mechanism from sambacc[1] via SAMBA_SPECIFICS env
variable to indicate the presence of new/replaced administrative
sub-command 'leader' for ctdb.

[1] samba-in-kubernetes/sambacc#50

Signed-off-by: Anoop C S <[email protected]>
phlogistonjohn pushed a commit to samba-in-kubernetes/samba-container that referenced this pull request Sep 21, 2022
Use the detection mechanism from sambacc[1] via SAMBA_SPECIFICS env
variable to indicate the presence of new/replaced administrative
sub-command 'leader' for ctdb.

[1] samba-in-kubernetes/sambacc#50

Signed-off-by: Anoop C S <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants