Pass global options to provision and join calls #45
Conversation
This will allow setting of smb.conf options at provision time. Signed-off-by: John Mulligan <[email protected]>
Signed-off-by: John Mulligan <[email protected]>
Apparently, I'm lazy and had not done it before. Signed-off-by: John Mulligan <[email protected]>
This allows the customization of samba DC configuration beyond the core parameters needed for domain provision or join. Signed-off-by: John Mulligan <[email protected]>
|
Unit tests are fine, but testing it practically I don't see the option making it into smb.conf, even though I've confirmed were passing the --option=foo=bar CLI arguments. I'm going to leave this as a draft until I do some more practical tests and understand what samba-tool expects the options to be. |
Signed-off-by: John Mulligan <[email protected]>
Signed-off-by: John Mulligan <[email protected]>
Signed-off-by: John Mulligan <[email protected]>
Signed-off-by: John Mulligan <[email protected]>
|
Getting the exact combination of CLI and smb.conf to work is proving tricky. I haven't given up on this tho. |
|
I can, unfortunately the code does not function as intended. I haven't had time to follow up on this as I think we'll need to better understand / discuss the behavior of samba-tool with regards to default options. JFYI |
|
Closed because this approach just won't work and it's been over 6 months outstanding. There's still an open issue to work on this which is not being closed. |
Support taking global options defined in the configuration and passing them onto the samba-tools commands that will generate smb.conf.
Fixes: #43