-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
commands: Add ctdb-check-ok #30
Conversation
Test: Ensure ctdb status is ok Run the new command and check return condition. Now disable and test the new command again with return condition. |
40106f7
to
e3e5711
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for looking into this, a few items inline:
The return value indicates the status of the ctdb service on the node. It is expected to be used as the readiness probe by kubernetes. Signed-off-by: Sachin Prabhu <[email protected]>
Signed-off-by: Sachin Prabhu <[email protected]>
Mode values to chmod are usually in octal. Signed-off-by: Sachin Prabhu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for finding and fixing the existing chmod issue!
The return value indicates the status of the ctdb service on the node.
It is expected to be used as the readiness probe by kubernetes.