sambacc: fix constructing interface list for ctdb public_addresses #134
Conversation
The samba wiki and documentation clearly state that the list of interfaces should be comma separated but I incorrectly joined them with spaces. Fix this and one other small suboptimal line in the same function. Signed-off-by: John Mulligan <[email protected]>
phlogistonjohn
force-pushed
the
jjm-fix-public-addrs
branch
from
a5c6347
to
05a1531
Compare
There was a problem hiding this comment.
The samba wiki and documentation clearly state that the list of interfaces should be comma separated but I incorrectly joined them with spaces. Fix this and one other small suboptimal line in the same function.
As a follow up to my previous #133 (comment), I wasn't aware of such a configuration with multiple interfaces until I thoroughly looked into man ctdb(7)(following @phlogistonjohn 's suggestion) to find just one example and that too under a specially catered "POLICY ROUTING" section. Judging from the details this is most likely an advanced network configuration which might have to be clubbed with some additional event scripts. But for now let's keep this option to specify multiple comma(,) separated interfaces for each network address.
Anyway it is a good find.
The samba wiki and documentation clearly state that the list of interfaces should be comma separated but I incorrectly joined them with spaces. Fix this and one other small suboptimal line in the same function.