ctdb: nodes list command, wait for ctdb option #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the ability to write to an already open file to cluster_meta_to_nodes. This will allow the function to be reused later to emit the nodes list to the stdout. Signed-off-by: John Mulligan <[email protected]>
Signed-off-by: John Mulligan <[email protected]>
Add a very simple ctdb-list-nodes subcommand that just takes the cluster meta information and then outputs the desired "nodes list"/"nodes file" content on the standard output. Signed-off-by: John Mulligan <[email protected]>
anoopcs9
reviewed
Jul 19, 2024
Signed-off-by: John Mulligan <[email protected]>
Add a `--wait-for=ctdb` option to the `samba-container run` subcommand. This option will make sambacc wait for the condition, ctdb available and returning a valid pnn, to be true before starting the server. Signed-off-by: John Mulligan <[email protected]>
phlogistonjohn
force-pushed
the
jjm-cmd-nodes-list
branch
from
2080471
to
7f0c171
Compare
phlogistonjohn
changed the title
synarete
reviewed
Aug 7, 2024
| @@ -704,6 +704,42 @@ def check_nodestatus(cmd: samba_cmds.SambaCommand = samba_cmds.ctdb) -> None: | |||
| samba_cmds.execute(cmd_ctdb_check) | |||
|
|
|||
|
|
|||
| def _read_command_pnn(cmd: samba_cmds.SambaCommand) -> typing.Optional[int]: | |||
There was a problem hiding this comment.
I am not a big fan of this mixed int-or-None return value. I would prefer a more explicit typing; something like tuple[int, bool]. But I guess its just a matter of style.
There was a problem hiding this comment.
Yeah, sorry but I find your suggestion less idiomatic. Hope you don't mind.
anoopcs9
reviewed
Aug 7, 2024
Put a time bounds on the code that waits for the conditions using a context manager that wraps alarm. Signed-off-by: John Mulligan <[email protected]>
anoopcs9
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
samba-container ctdb-list-nodescommand that emits a "nodes file" content to the stdout of the process.Add hooks to set up a ctdb "nodes_cmd" config file option that tells ctdb to execute a command to fetch the nodes rather than read a file.
Also add a
--wait-for=ctdboption to avoid starting certain services before ctdb is available and causing unnecessary container restarts.