-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ctdb: wrap reclock script #126
ctdb: wrap reclock script #126
Conversation
1856f92
to
51be3f8
Compare
🎉 All dependencies have been resolved ! |
This pull request now has conflicts with the target branch. Please resolve these conflicts and force push the updated branch. |
Signed-off-by: John Mulligan <[email protected]>
Parsing the URI(ish) string is not dependent on rados libs, move the parsing function to the module scope so that it can be reused elsewhere. Signed-off-by: John Mulligan <[email protected]>
This command is meant to serve as a direct wrapper around the `ctdb_mutex_ceph_rados_helper` command that "understands" some of the indended container workflow and argument style AND prevent issues in ctdb configuration where the cephx entity names are going to vary. Signed-off-by: John Mulligan <[email protected]>
51be3f8
to
7791eca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So we are looking forward to the following format inside ctdb.conf.
cluster lock = !samba-container ctdb-rados-mutex --cluster-name cephnew --ceph-id client.ctdb --mutex-uri rados://ctdb_pool/ctdb/cluster.lock
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 👍🏻.
Depends on: #124
Add a new
ctdb-rados-mutex
subcommand that is meant to serve as a direct wrapper around thectdb_mutex_ceph_rados_helper
command that "understands" some of theintended container workflow and argument style AND prevent issues in ctdb configuration where the cephx entity names are going to vary.