Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ctdb: wrap reclock script #126

Merged

Conversation

phlogistonjohn
Copy link
Collaborator

Depends on: #124

Add a new ctdb-rados-mutex subcommand that is meant to serve as a direct wrapper around the ctdb_mutex_ceph_rados_helper command that "understands" some of the
intended container workflow and argument style AND prevent issues in ctdb configuration where the cephx entity names are going to vary.

Copy link

dpulls bot commented Jul 2, 2024

🎉 All dependencies have been resolved !

Copy link

mergify bot commented Jul 2, 2024

This pull request now has conflicts with the target branch. Please resolve these conflicts and force push the updated branch.

Parsing the URI(ish) string is not dependent on rados libs, move the
parsing function to the module scope so that it can be reused elsewhere.

Signed-off-by: John Mulligan <[email protected]>
This command is meant to serve as a direct wrapper around the
`ctdb_mutex_ceph_rados_helper` command that "understands" some of the
indended container workflow and argument style AND prevent issues in
ctdb configuration where the cephx entity names are going to vary.

Signed-off-by: John Mulligan <[email protected]>
@phlogistonjohn phlogistonjohn marked this pull request as ready for review July 2, 2024 18:35
Copy link
Collaborator

@synarete synarete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@anoopcs9 anoopcs9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we are looking forward to the following format inside ctdb.conf.
cluster lock = !samba-container ctdb-rados-mutex --cluster-name cephnew --ceph-id client.ctdb --mutex-uri rados://ctdb_pool/ctdb/cluster.lock

sambacc/commands/ctdb.py Show resolved Hide resolved
Copy link
Collaborator

@anoopcs9 anoopcs9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍🏻.

@mergify mergify bot merged commit 0f220bc into samba-in-kubernetes:master Jul 3, 2024
9 checks passed
@phlogistonjohn phlogistonjohn deleted the jjm-ctdb-reclock-wrap branch July 6, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants