Extend support for ctdb cluster meta stored in ceph rados #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 All dependencies have been resolved ! |
|
This pull request now has conflicts with the target branch. Please resolve these conflicts and force push the updated branch. |
Previously, the class name was "private" and only expected to be used indirectly through the opener infrastructure. Future changes will make it possible to write "open" objects, lock them, etc. Prepare for that by making the class "public" and cleaning up the basic interface a bit. Signed-off-by: John Mulligan <[email protected]>
These will be used later to support cluster meta stored in rados. Signed-off-by: John Mulligan <[email protected]>
Add a method for getting a RADOSObjectRef based on a uri-like string, similar to the `rados_open` method that exists to support the urllib functionality. This includes a small refactor of the uri/url parsing so that it can be shared for both `get_object` and `rados_open`. Note that get_object advertises returning RADOSObjectRef so that special specific-to-rados APIs can be used easily. Signed-off-by: John Mulligan <[email protected]>
Add classes for the rados module to provide support for the ctdb module ClusterMeta protocols. The create_from_uri classmethod should be used to instantiate the new object as it hides the private _RADOSHandler type from other modules. Signed-off-by: John Mulligan <[email protected]>
Add `is_rados_uri` that will return true if a uri string containes a rados-specific scheme. Signed-off-by: John Mulligan <[email protected]>
Rename the `enable_rados_url_opener` to the more general `enable_rados` to reflect that calling this function enables rados support in sambacc not just sambacc's urlopener hooks. Signed-off-by: John Mulligan <[email protected]>
Add code to the ctdb related commands in sambacc to enable using a rados object as a cluster metatadata object. Signed-off-by: John Mulligan <[email protected]>
Add a command line argument that tells sambacc to source the ctdb node number from an environment variable. Signed-off-by: John Mulligan <[email protected]>
phlogistonjohn
force-pushed
the
jjm-rados-ctdb
branch
from
740707f
to
1810cf1
Compare
|
cc @avanthakkar |
avanthakkar
reviewed
Jun 27, 2024
avanthakkar
approved these changes
Jun 27, 2024
anoopcs9
changed the title
anoopcs9
requested changes
Jun 28, 2024
anoopcs9
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #122
Add support to rados module to implement the ClusterMeta protocol.
Add rados support to sambacc ctdb commands.
Add a helpful CLI option for getting node number from env (it's a bit unrelated to the rados focus of the other changes but I didn't want to file a whole PR just for that).