update black version #119
Merged
update black version #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 All dependencies have been resolved ! |
|
This pull request now has conflicts with the target branch. Please resolve these conflicts and force push the updated branch. |
Add docststrings to various protocol types. Some are a bit vague as these are protocols not concrete types. Signed-off-by: John Mulligan <[email protected]>
Add docststrings to various protocol types. Some are a bit vague as these are protocols not concrete types. Signed-off-by: John Mulligan <[email protected]>
Allow tox to use a version of the black tool from 2024. Having added
doc strings to protocols the black tool, using the 2024 style, will no
longer rewrite long-ish protocol method definitions that will span
multiple lines either way from:
def foo(a: str, b: str, c: SomethingCompletelyDifferent) -> int:
...
to
def foo(
a: str, b: str, c: SomethingCompletelyDifferent
) -> int: ...
Just to force the ellipsis to be on the "same line" as the definition.
This is change I find a bit unnecessary and a tad bit ugly. I did
report this to the black team but they chose to make the change anyway.
So they've unintentionally caused me to write more doc strings. Which is
a good thing I guess. :-)
Signed-off-by: John Mulligan <[email protected]>
phlogistonjohn
force-pushed
the
jjm-black-version
branch
from
a71faa5
to
c2af6e7
Compare
|
cc: @avanthakkar - for an additional review & peek into this code base |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on: #118
Add some docstrings and then update the version of the black formatter tool our tox envs are allowed to use.