Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extras: enable some recommended extras on centos 9 #103

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

phlogistonjohn
Copy link
Collaborator

@phlogistonjohn phlogistonjohn commented Jan 19, 2024

Recently, to enable features in the centos based version of the samba-container image I had to pull in a bunch of packages manually because the centos build of sambacc had no Recommends: configured.

This change updates the sambacc spec file to enable the recommends, minus the validation package, because that one doesn't have new enough dependencies in centos 9s repos to work.

@phlogistonjohn phlogistonjohn changed the title extras: try enabling the recommended extras on centos 9 extras: enable some recommended extras on centos 9 Jan 24, 2024
@phlogistonjohn phlogistonjohn marked this pull request as ready for review January 24, 2024 20:10
synarete
synarete previously approved these changes Jan 25, 2024
Copy link
Collaborator

@synarete synarete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mergify mergify bot merged commit e6376b9 into samba-in-kubernetes:master Jan 25, 2024
9 checks passed
@phlogistonjohn phlogistonjohn deleted the jjm-c9s-extras branch February 5, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants