Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report] Mobile Site - swiping too far inside of a code block opens the side menu #35

Open
3 of 11 tasks
juanri0s opened this issue Jul 23, 2020 · 0 comments
Open
3 of 11 tasks
Assignees

Comments

@juanri0s
Copy link

juanri0s commented Jul 23, 2020

Describe the bug

On mobile, if you scroll far enough in a code block, it will activate the side menu. Probably because the swipe to open action is active on the entire page which makes sense, but should probably be ignored in certain areas.

Steps to Reproduce

  1. Mobile Phone
  2. Go to any article on the site, for me 3 ways to clone objects in javascript
  3. Go to any code block that has horizontal scroll (doesn't wrap), for me 3. Using JSON
  4. Scroll to the right inside the code block (it's hit or miss sometimes but can be reproduced a good amount - but try and stay inside the code block when swiping, sometimes a small swipe works, sometimes it has to be a long swipe, sometimes you have to give it like 2 seconds and then try again (lol))

Expected Behavior

I expect that elements that have horizontal scroll on mobile will not activate any menus

Screenshots

None

Fix Suggestion

This isn't specific to Vue, I would assume its a common issue in JS and HTML. I haven't taken a look at the code and if I manage to figure it out I'll PR it but this can remain open to anyone. I guess you could stop propagation from bubbling up or prevent default on swipes on that class?

Browsers Affected

  • Whatever Instagram App built-in browser is
  • Mobile Safari
  • Chrome
  • Firefox
  • Edge
  • Safari 11
  • Safari 10
  • IE 11

Device Affected

  • Mobile
  • Tablet
  • Computer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants