Fix docker image grains pillar #54166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
waynew
force-pushed
the
fix-docker-image-grains-pillar
branch
from
a84b017
to
8249765
Compare
|
@dwoz tests are written now |
waynew
changed the title
waynew
force-pushed
the
fix-docker-image-grains-pillar
branch
2 times, most recently
from
e3956ba
to
4f6eed4
Compare
garethgreenaway
approved these changes
Aug 27, 2019
xeacott
approved these changes
Aug 27, 2019
dwoz
approved these changes
Aug 27, 2019
Ch3LL
approved these changes
Sep 3, 2019
Without this, the thin client that's passed to the docker container won't contain the proper grain/pillar information.
waynew
force-pushed
the
fix-docker-image-grains-pillar
branch
from
4f6eed4
to
ea21006
Compare
|
@waynew please address the linter and docs failures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds grains and pillar information to the thin client loaded onto docker images/containers
What issues does this PR fix or reference?
#53401
Previous Behavior
Grains were not getting set, so they were falling back to the default of the minion that was building the docker image. Pillar data was also not properly getting updated.
New Behavior
Grains + pillars are getting set
Tests written?
Yes
Commits signed with GPG?
Yes