[master] Improve pip target override condition with VENV_PIP_TARGET environment variable #65562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vzhestkov
requested review from
garethgreenaway
and removed request for
a team
salt-project-bot-prod-environment
bot
changed the title
3 tasks
dwoz
approved these changes
Nov 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In case of specifyig
bin_envthetargetwas populated fromVENV_PIP_TARGETenvironment variable which is not really needed as most probably the it will require separate target for such case, and it's better to use the default for this particular binary environment with no overriding the target fromVENV_PIP_TARGETPrevious Behavior
Overrides
targetin case if it's not specified explicitly for all cases.New Behavior
Overrides
targetfrom the environment variable only ifbin_envis not specified.Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes/No
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.