Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Hi,
I tried to snapshot a Btrfs subvolume with Salt, but the
btrfs.subvolume_snapshot
module didn't work on my machine.I ran this module from both a salt state on master and a salt-call on minion. Either way, I got an error message.
Looking at the code for this module, I believe the
source
argument was missing while building the cmd list.By appending
source
to the cmd list, a snapshot is now created and the command returns successfully.Previous Behavior
Error message on the minion:
Seems like the final command was:
btrfs subvolume snapshot [-r] <dest>
.New Behavior
Minion output:
The correct command should be:
btrfs subvolume snapshot [-r] <source> <dest>
.This PR adds the missing
<source>
argument.Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
No