Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Salt command names on macOS changed unexpectedly with onedir 3005 release #62665

Closed
sheagcraig opened this issue Sep 12, 2022 · 1 comment
Assignees
Labels
MacOS pertains to the OS of fruit Question The issue is more of a question rather than a bug or a feature request

Comments

@sheagcraig
Copy link
Contributor

Description
All of the standard salt commands on macOS have had no file type suffix. However, upon installing the new 3005 onedir package, they all have the .sh suffix, which leads to none of them being available for use from existing scripts except by updating them all. As none of the documentation for 3005 seems to reference this, I have to imagine this is an accident.

Setup
Install https://repo.saltproject.io/salt/py3/macos/latest/salt-3005-1-macos-x86_64.pkg on a Mac.
(Note-these commands won't work and will blow up on arm Macs: #62664)

Steps to Reproduce the behavior

  1. Try to run /opt/salt/bin/salt-call -V

Expected behavior
Salt commands retain their previous names and are called without a .sh extension, or are at least symlinked to the .sh one.

Versions Report
Unfortunately not possible given the openssl issues with ARM Mac right now.

@sheagcraig sheagcraig added Bug broken, incorrect, or confusing behavior needs-triage labels Sep 12, 2022
@OrangeDog OrangeDog added Regression The issue is a bug that breaks functionality known to work in previous releases. MacOS pertains to the OS of fruit Phosphorus v3005.0 Release code name and version labels Sep 13, 2022
@anilsil anilsil added this to the Sulfur v3006.1 milestone Apr 18, 2023
@twangboy
Copy link
Contributor

This is because the package you downloaded is a Tiamat package. The paradigm is different for Tiamat packages. There is a single binary called salt. All Salt components are arguments to salt.exe. So, to run a minion, for example, the command would be salt minion. To try to maintain expected behavior, we added the .sh scripts to mimic the binaries that used to be present.

If you want a 3005 version with the old binaries, you can download one of the classic packages here: https://repo.saltproject.io/osx/

Starting with 3006, the onedir packages have binaries just like the classic packages. So, it shouldn't be a problem going forward.

@twangboy twangboy added Question The issue is more of a question rather than a bug or a feature request and removed Bug broken, incorrect, or confusing behavior Regression The issue is a bug that breaks functionality known to work in previous releases. needs-triage Phosphorus v3005.0 Release code name and version labels Apr 28, 2023
@twangboy twangboy removed this from the Sulfur v3006.1 milestone Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MacOS pertains to the OS of fruit Question The issue is more of a question rather than a bug or a feature request
Projects
None yet
Development

No branches or pull requests

5 participants