Remove the PyObjC dependency #62432
Merged
Remove the PyObjC dependency #62432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twangboy
previously approved these changes
Aug 5, 2022
s0undt3ch
force-pushed
the
hotfix/tiamat-ld-library-path
branch
from
1a6a4ba
to
e34357d
Compare
Signed-off-by: Pedro Algarvio <[email protected]>
s0undt3ch
force-pushed
the
hotfix/tiamat-ld-library-path
branch
from
e34357d
to
887f0ba
Compare
Ch3LL
approved these changes
Aug 5, 2022
twangboy
approved these changes
Aug 5, 2022
SMillerDev
approved these changes
Aug 7, 2022
Thank You for the input. |
|
The required approvals are in and tests have passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
See title.
What issues does this PR fix or reference?
This addresses problems with building a one dir build for macOS.
It becomes even more problematic because depending on the macOS version, it pulls different dependencies, and we would either have to build a macos onedir for each macOS supported release, or ship a crippled onedir(because it would be tied to the macOS version where the onedir was built)