[FEATURE REQUEST] salt dig module: dig.x

[matthewsaum]

Is your feature request related to a problem? Please describe.
I love the use of salt modules, both in my jinja templates and for regular system administration, but I find the ability to do a reverse-lookup of an IP somewhat lacking.

Describe the solution you'd like
The salt module dig has a handful of useful functions already, the most-used being dig.A, so I suggest trying to get dig.x to also work.

Describe alternatives you've considered
I've been running cmd.shell host 1.2.3.4 and other such workarounds, but a module would be great.

Additional context

Please Note
If this feature request would be considered a substantial change or addition, this should go through a SEP process here https://github.com/saltstack/salt-enhancement-proposals, instead of a feature request.

[welcome]

Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here’s some information that may help as you continue your Salt journey.
Please be sure to review our Code of Conduct. Also, check out some of our community resources including:

• Community Wiki
• Salt’s Contributor Guide
• Join our Community Slack
• IRC on LiberaChat
• Salt Project YouTube channel
• Salt Project Twitch channel

There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar.
If you have additional questions, email us at [email protected]. We’re glad you’ve joined our community and look forward to doing awesome things with you!

[matthewsaum]

I added a block in a local module in my environment. Just felt it ought to be pushed upward for proper integration.

def X(host, nameserver=None):
    '''
    Return the PTR record for ``host``.

    Always returns a list.

    CLI Example:

    .. code-block:: bash

        salt ns1 dig.X 1.2.3.4
    '''
    dig = ['dig', '+short', '-x', six.text_type(host) ]

    if nameserver is not None:
        dig.append('@{0}'.format(nameserver))

    cmd = __salt__['cmd.run_all'](dig, python_shell=False)

    if cmd['retcode'] != 0:
        log.warning(
            'dig returned exit code \'{0}\'. Returning empty list as '
            'fallback.'.format(
                cmd['retcode']
            )
        )
        return []

    return [i for i in cmd['stdout'].split('\n')]

[nicholasmhughes]

@matthewsaum , that's great! Would you be willing to put that functionality into a PR? It would only need a couple of basic unit tests See #61992 for ideas on how to make that happen and feel free to ping me with any additional questions.

[matthewsaum]

@nicholasmhughes Happy to try to figure it out. I'll see if I can get it working and get back to you before end of day Friday.

[matthewsaum]

Please to report I've got documentation and a local dev environment running. I'll poke it and get a proper test suite run and have a merge request incoming.

[matthewsaum]

So I learned a bit more about things while doing that first attempted Pull Request. New PR should be popping up shortly.

[nicholasmhughes]

Closed by #62314