[beacons.network_settings] adopt new pyroute2 API #62218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... and prepare for pyroute2.IPDB to be dropped. This commit provides no logic change, only some compat code. Reason: pyroute2.IPDB will be dropped in future releases, and the successor module pyroute2.NDB does not provide a drop-in replacement API. Solution: use NDB if ipdb_interfaces_view() is available (will be available @ pyroute2 >= 0.7.1), otherwise fall back to IPDB (while it's provided).
|
Not sure why |
|
@svinota Can you add a changelog for these changes? |
|
@garethgreenaway sure thing, will be done tomorrow |
|
@svinota Thanks! |
|
@garethgreenaway done |
garethgreenaway
approved these changes
Oct 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... and prepare for pyroute2.IPDB to be dropped.
This commit provides no logic change, only some compat code.
Reason: pyroute2.IPDB will be dropped in future releases, and
the successor module pyroute2.NDB does not provide a drop-in
replacement API.
Solution: use NDB if ipdb_interfaces_view() is available
(will be available @ pyroute2 >= 0.7.1), otherwise fall back
to IPDB (while it's provided).
Related: svinota/pyroute2#788