macosxsierra and macoshighsierra jenkins jobs fail to bootstrap at timelib installation step

[DmitryKuzmenko]

Description of Issue

https://jenkinsci.saltstack.com/job/pr-macosxsierra-py3/job/master/505/console
https://jenkinsci.saltstack.com/job/pr-macosxhighsierra-py3/job/master/514/console

[2020-02-10T10:26:23.488Z]          clang -Wno-unused-result -Wsign-compare -Wunreachable-code -fno-common -dynamic -DNDEBUG -g -fwrapv -O3 -Wall -DHAVE_STRING_H=1 -I/usr/local/include -I/usr/local/opt/openssl/include -I/usr/local/opt/sqlite/include -I/private/tmp/kitchen/testing/.nox/runtests-parametrized-3-coverage-true-crypto-none-transport-zeromq/include -I/usr/local/opt/python/Frameworks/Python.framework/Versions/3.7/include/python3.7m -c ext-date-lib/astro.c -o build/temp.macosx-10.12-x86_64-3.7/ext-date-lib/astro.o
[2020-02-10T10:26:23.488Z]          In file included from ext-date-lib/astro.c:26:
[2020-02-10T10:26:23.488Z]          In file included from ext-date-lib/timelib.h:24:
[2020-02-10T10:26:23.488Z]          ext-date-lib/timelib_structs.h:24:10: fatal error: 'timelib_config.h' file not found
[2020-02-10T10:26:23.488Z]          #include "timelib_config.h"
[2020-02-10T10:26:23.488Z]            ^
[2020-02-10T10:26:23.488Z]          1 error generated.
[2020-02-10T10:26:23.488Z]          error: command 'clang' failed with exit status 1

[Ch3LL]

looks like these are bootstrapping tests now again. thanks @s0undt3ch :)

[marco-m]

hello @Ch3LL,
trying to pip install --edit the current salt master branch I stumbled upon this error.
You closed this issue but there is no associated PR or commit, what does it mean? Thanks :-)

[Ch3LL]

this is an upstream issue here: pediapress/timelib#6

we ended up building our own timelib with the workaround for our test suite. If you are using the macosx packages we provide you should not see this issue though as we build on a OS that does not exhibit this behavior.

[marco-m]

If you are using the macosx packages we provide you should not see this issue

When I install salt, this is correct, I don't see this issue.

But, I see it when I want to develop salt itself: I follow the instructions at https://docs.saltstack.com/en/latest/topics/development/hacking.html:

and I do

pip install -e ./salt 

as mentioned in my first message above.

[Ch3LL]

does the workaround in the timelib issue work for you? pediapress/timelib#6 (comment)

also @weswhet curious if you have ever run into this and how you workaround it?

[marco-m]

I had a look at the workaround but I gave up, the experience of bringing up salt for development depleted my energy :-)

I now export PYTHONPATH=salt (where salt is the relative path to the salt git repo) and I can at least start salt-ssh (I want to do some changes to this component). I hope this will be enough, I will see.

My point is that the current instructions in the SaltStack site to develop salt, https://docs.saltstack.com/en/latest/topics/development/hacking.html, are broken at least for macOS.

If you want, I can create another ticket about the documentation ?

And by the way, thanks for helping.

[weswhet]

Hmm I’ve never seen this. I’m working on some separate build issues on Catalina. Those issues appear to be upstream with ZeroMQ

[weswhet]

and just ran into this.

[tonythebest]

I ran into this too on MacBook