Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The documentation on the readme for the bootstrap script should make more use of stable instead of git. #1524

Closed
whytewolf opened this issue Jan 13, 2021 · 5 comments

Comments

@whytewolf
Copy link

Description of Issue/Question

Currently, the readme on the github link uses lots of examples of git. however, when using the bootstrap script in production environments this is not what should be used. And without reading more in-depth documentation one would think git is the only operation.

most of the examples should be a mix of git and stable. with a section explaining that these refer to the different kinds of installs.
And that for production you most likely want stable. while this documentation does exist elsewhere not many are going to go looking for that documentation when there is documentation right here.

Steps to Reproduce Issue

Just read the README on the github page.

@ScriptAutomate
Copy link
Contributor

This would also help prevent problems like saltstack/salt#59366 coming up. We need to make it clearer that people should be using stable, and that people should only be using git if they have special use cases perhaps around testing new features that haven't been included in a release yet.

@sagetherage
Copy link

Interesting, the readme is dated and oddly enough the use of the word stable seems more correct, but we stopped using it at some point and it can be controversial when we use it instead of latest in Salt, so not to confuse this here, but to simply point it out or plus one - the readme needs updating in this repo, for sure!

@whytewolf
Copy link
Author

@sagetherage the use of stable in this context is actually an option to the bootstrap script. latest is a version stable is the method of that release. so bootstrap.sh stable 3001 would point to the 3001 repo. whereas bootstap.sh git v3001.1 would install from git

And while the readme has been updated to include references to stable. it isn't made clear that stable would be the preferred and better option to use production environment.

@sagetherage
Copy link

yes, I made a strange reference. I mean I agree with this issue and we need to fix it.

@dmurphy18
Copy link
Contributor

@whytewolf Closing since merged in update of README

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants