users.user_files does not work correctly when using gitfs backend

[johnccfm]

In the users.user_files state there is this code to get a list of directories matching "/users/files/user/":-

{% set userfile_dirs = salt['cp.list_master_dirs'](prefix='users/files/user/') -%}

If no explicit source path is specified in the pillar will try to match 'users/files/user/' ~ username against this list. If it finds no match, it will skip the user completely.

The problem is that when using gitfs, cp.list_master_dirs only lists local directories on the master so there's a good chance your salt://users/files will not be in that list. This means that the state will always do nothing.

The workaround is to specify an explicit source for each user, e.g. salt://users/files/user/joeblogs