Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot override --check-order #587

Closed
ibarsi opened this issue Apr 2, 2020 · 0 comments · Fixed by #588
Closed

Cannot override --check-order #587

ibarsi opened this issue Apr 2, 2020 · 0 comments · Fixed by #588

Comments

@ibarsi
Copy link

ibarsi commented Apr 2, 2020

Since the latest minor version bump (4.5.0) we've been unable to override --check-order. I believe this was due to the change introduced in #585. Since CHECK_ORDER can legitimately be false, the || always defaults to true. Meaning, the order is always checked.

We should remove the default to true since this should already be covered when setting CHECK_ORDER.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Do provide default cli option value only if not specified salsita/node-pg-migrate
1 participant
@ibarsi