Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TriggerOptions vs TriggerOptionsEn #491

Closed
ab-pm opened this issue Oct 4, 2019 · 2 comments · Fixed by #494
Closed

TriggerOptions vs TriggerOptionsEn #491

ab-pm opened this issue Oct 4, 2019 · 2 comments · Fixed by #494

Comments

@ab-pm
Copy link
Contributor

ab-pm commented Oct 4, 2019

Hi, I'm not sure why those are two separate types. createTrigger should not take any FunctionOptions, so why is that merged in the union type? My compiler always complains because I am not supplying a language property for my triggers, which is mandatory for functions.
@dolezel
Copy link
Contributor

dolezel commented Oct 10, 2019

You can also create a function for trigger directly in one call, but that should be only optional. I will check...

@dolezel dolezel mentioned this issue Oct 10, 2019
Merged
@ab-pm
Copy link
Contributor Author

ab-pm commented Oct 10, 2019

Thanks, the function overload solves this perfectly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixing createTrigger TS type salsita/node-pg-migrate
2 participants
@dolezel @ab-pm