Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comments broken columns with createTable(object, ...) #227

Closed
frankdugan3 opened this issue Mar 23, 2018 · 1 comment
Closed

Comments broken columns with createTable(object, ...) #227

frankdugan3 opened this issue Mar 23, 2018 · 1 comment

Comments

@frankdugan3
Copy link

frankdugan3 commented Mar 23, 2018 •
edited
Loading

When running createTable() with an object for the table name, I am unable to use column comments. It throws this error: relation "[object Object]" does not exist. I think the column comment function just needs to check if the table name is an object and build the appropriate string if it is.

The SQL generated is this: COMMENT ON COLUMN "[object Object]"."column"
@dolezel dolezel mentioned this issue Mar 23, 2018
Merged
@frankdugan3
Copy link
Author

Wow, that was quick. Thanks @dolezel !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@frankdugan3