Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is headerModules working fine for you? weird concat.build overriding #191

Open
brunomacf opened this issue Apr 28, 2020 · 1 comment
Open

Comments

@brunomacf
Copy link

brunomacf commented Apr 28, 2020

I'm using this config in a addon i'm working on

cssModules: {
  headerModules: [
    'addon/styles/mystyle.scss',
  ],
  extension: 'scss',
  intermediateOutputPath: 'app/styles/_modules.scss',
}

Where i have a sass variable declared addon/styles/mystyle.scss' used by other components in the addon. I tracked the issue down and it seems the problem is in this line:

https://github.com/salsify/ember-css-modules/blob/master/packages/ember-css-modules/lib/output-styles-preprocessor.js#L64

We are overriding concat.build and when it gets called fixedHeaders is empty for some reason... although i'm seeing correct fixedHeaders if i log it outside concat.build.

Edit: I'm using ember-cli 3.17.3.

@lolmaus
Copy link

lolmaus commented May 11, 2020

Please mention concat.build overriding in issue title, since without concat.build it's working fine for you and me.

@brunomacf brunomacf changed the title Is headerModules working fine for you? Is headerModules working fine for you? weird concat.build overriding May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants