Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

salsaflow.modules.codereview.github: The daemon panics when !mustfix is used on a commit that is not associated with any review issue #19

Open
tchap opened this issue Nov 20, 2015 · 0 comments

Comments

@tchap
Copy link
Member

tchap commented Nov 20, 2015

Nov 20 07:46:13 salsaflow-daemon app/web.1:  [negroni] PANIC: runtime error: invalid memory address or nil pointer dereference 
Nov 20 07:46:13 salsaflow-daemon app/web.1:  goroutine 1732 [running]: 
Nov 20 07:46:13 salsaflow-daemon app/web.1:  github.com/codegangsta/negroni.(*Recovery).ServeHTTP.func1(0x7efe04cd0ca8, 0xc8204ac2c0, 0xc82000f1a0) 
Nov 20 07:46:13 salsaflow-daemon app/web.1:     /tmp/build_6899d3cf1cfd9713652693b83b455bb2/.heroku/go/src/github.com/salsaflow/salsaflow-daemon/Godeps/_workspace/src/github.com/codegangsta/negroni/recovery.go:34 +0xe9 
Nov 20 07:46:13 salsaflow-daemon app/web.1:  github.com/salsaflow/salsaflow/github/issues.ParseReviewIssue(0x0, 0x0, 0x0, 0x0, 0x0) 
Nov 20 07:46:13 salsaflow-daemon app/web.1:     /tmp/build_6899d3cf1cfd9713652693b83b455bb2/.heroku/go/src/github.com/salsaflow/salsaflow-daemon/Godeps/_workspace/src/github.com/salsaflow/salsaflow/github/issues/review_issue.go:39 +0x4b 
Nov 20 07:46:13 salsaflow-daemon app/web.1:  github.com/salsaflow/salsaflow-daemon/internal/modules/codereview/github/endpoint.(*eventHandler).createReviewBlockerFromCommitComment(0xc8200240c0, 0xc820248000, 0xc8204c0510, 0x7, 0xc8204c04e0, 0x9, 0xc8204b6000, 0xc8204b8bd9, 0x25, 0x0, ...) 
Nov 20 07:46:13 salsaflow-daemon app/web.1:     /tmp/build_6899d3cf1cfd9713652693b83b455bb2/.heroku/go/src/github.com/salsaflow/salsaflow-daemon/internal/modules/codereview/github/endpoint/events_commit_comment.go:90 +0x158 
Nov 20 07:46:13 salsaflow-daemon app/web.1:  github.com/salsaflow/salsaflow-daemon/internal/modules/codereview/github/endpoint.(*eventHandler).HandleCommitCommentEvent(0xc8200240c0, 0x7efe04cd0ca8, 0xc8204ac480, 0xc820248000, 0xc8204ba480) 
Nov 20 07:46:13 salsaflow-daemon app/web.1:     /tmp/build_6899d3cf1cfd9713652693b83b455bb2/.heroku/go/src/github.com/salsaflow/salsaflow-daemon/internal/modules/codereview/github/endpoint/events_commit_comment.go:51 +0x3d1 
Nov 20 07:46:13 salsaflow-daemon app/web.1:  github.com/salsaflow/salsaflow-daemon/internal/github.glob.func2.1(0x7efe04cd0ca8, 0xc8204ac480, 0xc820248000) 
Nov 20 07:46:13 salsaflow-daemon app/web.1:     /tmp/build_6899d3cf1cfd9713652693b83b455bb2/.heroku/go/src/github.com/salsaflow/salsaflow-daemon/internal/github/handler.go:88 +0x202 
Nov 20 07:46:13 salsaflow-daemon app/web.1:  net/http.HandlerFunc.ServeHTTP(0xc8204ba460, 0x7efe04cd0ca8, 0xc8204ac480, 0xc820248000) 
Nov 20 07:46:13 salsaflow-daemon app/web.1:     /usr/local/go/src/net/http/server.go:1422 +0x3a 
Nov 20 07:46:13 salsaflow-daemon app/web.1:  github.com/salsaflow/salsaflow-daemon/internal/github.(*WebhookHandler).handleEvent(0xc82000ed20, 0x7efe04cd0ca8, 0xc8204ac480, 0xc820248000) 
Nov 20 07:46:13 salsaflow-daemon app/web.1:     /tmp/build_6899d3cf1cfd9713652693b83b455bb2/.heroku/go/src/github.com/salsaflow/salsaflow-daemon/internal/github/handler.go:64 +0xbe 
Nov 20 07:46:13 salsaflow-daemon app/web.1:  github.com/salsaflow/salsaflow-daemon/internal/github.(*WebhookHandler).(github.com/salsaflow/salsaflow-daemon/internal/github.handleEvent)-fm(0x7efe04cd0ca8, 0xc8204ac480, 0xc820248000) 
Nov 20 07:46:13 salsaflow-daemon app/web.1:     /tmp/build_6899d3cf1cfd9713652693b83b455bb2/.heroku/go/src/github.com/salsaflow/salsaflow-daemon/internal/github/handler.go:53 +0x3e 
Nov 20 07:46:13 salsaflow-daemon app/web.1:  net/http.HandlerFunc.ServeHTTP(0xc8200b1710, 0x7efe04cd0ca8, 0xc8204ac480, 0xc820248000) 
Nov 20 07:46:13 salsaflow-daemon app/web.1:     /usr/local/go/src/net/http/server.go:1422 +0x3a 
Nov 20 07:46:13 salsaflow-daemon app/web.1:  github.com/codegangsta/negroni.Wrap.func1(0x7efe04cd0ca8, 0xc8204ac480, 0xc820248000, 0xc8204ba400) 
Nov 20 07:46:13 salsaflow-daemon app/web.1:     /tmp/build_6899d3cf1cfd9713652693b83b455bb2/.heroku/go/src/github.com/salsaflow/salsaflow-daemon/Godeps/_workspace/src/github.com/codegangsta/negroni/negroni.go:41 +0x50 
Nov 20 07:46:13 salsaflow-daemon app/web.1:  github.com/codegangsta/negroni.HandlerFunc.ServeHTTP(0xc82000ede0, 0x7efe04cd0ca8, 0xc8204ac480, 0xc820248000, 0xc8204ba400) 
Nov 20 07:46:13 salsaflow-daemon app/web.1:     /tmp/build_6899d3cf1cfd9713652693b83b455bb2/.heroku/go/src/github.com/salsaflow/salsaflow-daemon/Godeps/_workspace/src/github.com/codegangsta/negroni/negroni.go:24 +0x44 
Nov 20 07:46:13 salsaflow-daemon app/web.1:  github.com/codegangsta/negroni.middleware.ServeHTTP(0x7efe04ccf808, 0xc82000ede0, 0xc82000ee40, 0x7efe04cd0ca8, 0xc8204ac480, 0xc820248000) 
Nov 20 07:46:13 salsaflow-daemon app/web.1:     /tmp/build_6899d3cf1cfd9713652693b83b455bb2/.heroku/go/src/github.com/salsaflow/salsaflow-daemon/Godeps/_workspace/src/github.com/codegangsta/negroni/negroni.go:33 +0xaa 
Nov 20 07:46:13 salsaflow-daemon app/web.1:  github.com/codegangsta/negroni.(middleware).ServeHTTP-fm(0x7efe04cd0ca8, 0xc8204ac480, 0xc820248000) 
Nov 20 07:46:13 salsaflow-daemon app/web.1:     /tmp/build_6899d3cf1cfd9713652693b83b455bb2/.heroku/go/src/github.com/salsaflow/salsaflow-daemon/Godeps/_workspace/src/github.com/codegangsta/negroni/negroni.go:33 +0x53 
Nov 20 07:46:13 salsaflow-daemon app/web.1:  github.com/salsaflow/salsaflow-daemon/internal/github.newSecretMiddleware.func1(0x7efe04cd0ca8, 0xc8204ac480, 0xc820248000, 0xc8204ba340) 
Nov 20 07:46:13 salsaflow-daemon app/web.1:     /tmp/build_6899d3cf1cfd9713652693b83b455bb2/.heroku/go/src/github.com/salsaflow/salsaflow-daemon/internal/github/middleware.go:53 +0x609 
Nov 20 07:46:13 salsaflow-daemon app/web.1:  github.com/codegangsta/negroni.HandlerFunc.ServeHTTP(0xc82000ed80, 0x7efe04cd0ca8, 0xc8204ac480, 0xc820248000, 0xc8204ba340) 
Nov 20 07:46:13 salsaflow-daemon app/web.1:     /tmp/build_6899d3cf1cfd9713652693b83b455bb2/.heroku/go/src/github.com/salsaflow/salsaflow-daemon/Godeps/_workspace/src/github.com/codegangsta/negroni/negroni.go:24 +0x44 
Nov 20 07:46:13 salsaflow-daemon app/web.1:  github.com/codegangsta/negroni.middleware.ServeHTTP(0x7efe04ccf808, 0xc82000ed80, 0xc82000ee20, 0x7efe04cd0ca8, 0xc8204ac480, 0xc820248000) 
Nov 20 07:46:13 salsaflow-daemon app/web.1:     /tmp/build_6899d3cf1cfd9713652693b83b455bb2/.heroku/go/src/github.com/salsaflow/salsaflow-daemon/Godeps/_workspace/src/github.com/codegangsta/negroni/negroni.go:33 +0xaa 
Nov 20 07:46:13 salsaflow-daemon app/web.1:  github.com/codegangsta/negroni.(*Negroni).ServeHTTP(0xc8200136e0, 0x7efe04cd0ca8, 0xc8204ac2c0, 0xc820248000) 
Nov 20 07:46:13 salsaflow-daemon app/web.1:     /tmp/build_6899d3cf1cfd9713652693b83b455bb2/.heroku/go/src/github.com/salsaflow/salsaflow-daemon/Godeps/_workspace/src/github.com/codegangsta/negroni/negroni.go:73 +0x122 
Nov 20 07:46:13 salsaflow-daemon app/web.1:  github.com/salsaflow/salsaflow-daemon/internal/github.(*WebhookHandler).ServeHTTP(0xc82000ed20, 0x7efe04cd0ca8, 0xc8204ac2c0, 0xc820248000) 
Nov 20 07:46:13 salsaflow-daemon app/web.1:     <autogenerated>:1 +0x6d 
Nov 20 07:46:13 salsaflow-daemon app/web.1:  net/http.(*ServeMux).ServeHTTP(0xc820013740, 0x7efe04cd0ca8, 0xc8204ac2c0, 0xc820248000) 
Nov 20 07:46:13 salsaflow-daemon app/web.1:     /usr/local/go/src/net/http/server.go:1699 +0x17d 
Nov 20 07:46:13 salsaflow-daemon app/web.1:  net/http.StripPrefix.func1(0x7efe04cd0ca8, 0xc8204ac2c0, 0xc820248000) 
Nov 20 07:46:13 salsaflow-daemon app/web.1:     /usr/local/go/src/net/http/server.go:1455 +0x1a5 
Nov 20 07:46:13 salsaflow-daemon app/web.1:  net/http.HandlerFunc.ServeHTTP(0xc8200137a0, 0x7efe04cd0ca8, 0xc8204ac2c0, 0xc820248000) 
Nov 20 07:46:13 salsaflow-daemon app/web.1:     /usr/local/go/src/net/http/server.go:1422 +0x3a 
Nov 20 07:46:13 salsaflow-daemon app/web.1:  net/http.(*ServeMux).ServeHTTP(0xc820013620, 0x7efe04cd0ca8, 0xc8204ac2c0, 0xc820248000) 
Nov 20 07:46:13 salsaflow-daemon app/web.1:     /usr/local/go/src/net/http/server.go:1699 +0x17d 
Nov 20 07:46:13 salsaflow-daemon app/web.1:  github.com/codegangsta/negroni.Wrap.func1(0x7efe04cd0ca8, 0xc8204ac2c0, 0xc820248000, 0xc8204ba320) 
Nov 20 07:46:13 salsaflow-daemon app/web.1:     /tmp/build_6899d3cf1cfd9713652693b83b455bb2/.heroku/go/src/github.com/salsaflow/salsaflow-daemon/Godeps/_workspace/src/github.com/codegangsta/negroni/negroni.go:41 +0x50 
Nov 20 07:46:13 salsaflow-daemon app/web.1:  github.com/codegangsta/negroni.HandlerFunc.ServeHTTP(0xc82000f2e0, 0x7efe04cd0ca8, 0xc8204ac2c0, 0xc820248000, 0xc8204ba320) 
Nov 20 07:46:13 salsaflow-daemon app/web.1:     /tmp/build_6899d3cf1cfd9713652693b83b455bb2/.heroku/go/src/github.com/salsaflow/salsaflow-daemon/Godeps/_workspace/src/github.com/codegangsta/negroni/negroni.go:24 +0x44 
Nov 20 07:46:13 salsaflow-daemon app/web.1:  github.com/codegangsta/negroni.middleware.ServeHTTP(0x7efe04ccf808, 0xc82000f2e0, 0xc82000f380, 0x7efe04cd0ca8, 0xc8204ac2c0, 0xc820248000) 
Nov 20 07:46:13 salsaflow-daemon app/web.1:     /tmp/build_6899d3cf1cfd9713652693b83b455bb2/.heroku/go/src/github.com/salsaflow/salsaflow-daemon/Godeps/_workspace/src/github.com/codegangsta/negroni/negroni.go:33 +0xaa 
Nov 20 07:46:13 salsaflow-daemon app/web.1:  github.com/codegangsta/negroni.(middleware).ServeHTTP-fm(0x7efe04cd0ca8, 0xc8204ac2c0, 0xc820248000) 
Nov 20 07:46:13 salsaflow-daemon app/web.1:     /tmp/build_6899d3cf1cfd9713652693b83b455bb2/.heroku/go/src/github.com/salsaflow/salsaflow-daemon/Godeps/_workspace/src/github.com/codegangsta/negroni/negroni.go:33 +0x53 
Nov 20 07:46:13 salsaflow-daemon app/web.1:  main.newRewriteObsoletePathsMiddleware.func1(0x7efe04cd0ca8, 0xc8204ac2c0, 0xc820248000, 0xc8204ba300) 
Nov 20 07:46:13 salsaflow-daemon app/web.1:     /tmp/build_6899d3cf1cfd9713652693b83b455bb2/.heroku/go/src/github.com/salsaflow/salsaflow-daemon/main.go:53 +0xb7 
Nov 20 07:46:13 salsaflow-daemon app/web.1:  github.com/codegangsta/negroni.HandlerFunc.ServeHTTP(0x9468f8, 0x7efe04cd0ca8, 0xc8204ac2c0, 0xc820248000, 0xc8204ba300) 
Nov 20 07:46:13 salsaflow-daemon app/web.1:     /tmp/build_6899d3cf1cfd9713652693b83b455bb2/.heroku/go/src/github.com/salsaflow/salsaflow-daemon/Godeps/_workspace/src/github.com/codegangsta/negroni/negroni.go:24 +0x44 
Nov 20 07:46:13 salsaflow-daemon app/web.1:  github.com/codegangsta/negroni.middleware.ServeHTTP(0x7efe04ccf808, 0x9468f8, 0xc82000f360, 0x7efe04cd0ca8, 0xc8204ac2c0, 0xc820248000) 
Nov 20 07:46:13 salsaflow-daemon app/web.1:     /tmp/build_6899d3cf1cfd9713652693b83b455bb2/.heroku/go/src/github.com/salsaflow/salsaflow-daemon/Godeps/_workspace/src/github.com/codegangsta/negroni/negroni.go:33 +0xaa 
Nov 20 07:46:13 salsaflow-daemon app/web.1:  github.com/codegangsta/negroni.(middleware).ServeHTTP-fm(0x7efe04cd0ca8, 0xc8204ac2c0, 0xc820248000) 
Nov 20 07:46:13 salsaflow-daemon app/web.1:     /tmp/build_6899d3cf1cfd9713652693b83b455bb2/.heroku/go/src/github.com/salsaflow/salsaflow-daemon/Godeps/_workspace/src/github.com/codegangsta/negroni/negroni.go:33 +0x53 
Nov 20 07:46:13 salsaflow-daemon app/web.1:  github.com/codegangsta/negroni.(*Static).ServeHTTP(0xc820013aa0, 0x7efe04cd0ca8, 0xc8204ac2c0, 0xc820248000, 0xc8204ba2a0) 
Nov 20 07:46:13 salsaflow-daemon app/web.1:     /tmp/build_6899d3cf1cfd9713652693b83b455bb2/.heroku/go/src/github.com/salsaflow/salsaflow-daemon/Godeps/_workspace/src/github.com/codegangsta/negroni/static.go:30 +0x9f9 
Nov 20 07:46:13 salsaflow-daemon app/web.1:  github.com/codegangsta/negroni.middleware.ServeHTTP(0x7efe04ccf970, 0xc820013aa0, 0xc82000f340, 0x7efe04cd0ca8, 0xc8204ac2c0, 0xc820248000) 
Nov 20 07:46:13 salsaflow-daemon app/web.1:     /tmp/build 
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant