You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Nov 22, 2021. It is now read-only.
Key bindings (Repost, Like, ..) seems to be highlighted when using search or other input forms. The trigger should probably check for this before firing (seems to be purely cosmetic though, the actual repost or like action doesn't fire).
The text was updated successfully, but these errors were encountered:
There are measures taken not to trigger those key binding when typing inputs.
Avoiding menu item highlights is s little trickier. The problem is, shortcuts like "L for Like" are implemented on soundcloud.com itself, the shortcut on the menu item is only relevant when the main window does not have keyboard focus (minimized, in background, etc).
The proper solution would disable the menu shortcuts when the main window is focused and re-enable them on blur. I did not investigate whether this is doable with Electron or not, but a pull request to improve is always welcome.
salomvary
changed the title
Don't trigger key bindings when using search forms
Don't highlight menus with key bindings when typing text into inputs
Aug 27, 2018
Key bindings (Repost, Like, ..) seems to be highlighted when using search or other input forms. The trigger should probably check for this before firing (seems to be purely cosmetic though, the actual repost or like action doesn't fire).
The text was updated successfully, but these errors were encountered: