Fix quizz screen when no question matches criteria

sallesma · Feb 25, 2024 · 59f04d9 · 59f04d9
1 parent 50484f1
commit 59f04d9
Show file tree

Hide file tree

Showing 5 changed files with 45 additions and 0 deletions.
diff --git a/src/screens/QuizzScreen.js b/src/screens/QuizzScreen.js
@@ -31,6 +31,12 @@ export default (props) => {
       (level === Levels.ANY || level === question.level) &&
       (checkedCategories.length === 0 || checkedCategories.includes(question.category)),
   );
+  if (filteredQuestions.length === 0)
+    return (
+      <ScrollView style={styles.container} contentContainerStyle={styles.contentContainer}>
+        <Text>{I18n.t('quizzScreen.noQuestions')}</Text>
+      </ScrollView>
+    );
 
   const [selectedQuestions, _setSelectedQuestions] = useState(getRandomElementsFromArray(filteredQuestions, number));
   const [current, setCurrent] = useState(1);

diff --git a/src/screens/__tests__/QuizzScreen.test.js b/src/screens/__tests__/QuizzScreen.test.js
@@ -28,4 +28,19 @@ describe('<QuizzScreen />', () => {
 
     expect(toJSON()).toMatchSnapshot();
   });
+
+  it('renders correctly with no questions', async () => {
+    const navigation = { setOptions: jest.fn() };
+    const route = {
+      params: {
+        number: 5,
+        time: 30,
+        level: Levels.DIFFICULT,
+        checkedCategories: [Categories.INDOOR],
+      },
+    };
+    const { toJSON, getByText } = render(<QuizzScreen navigation={navigation} route={route} />);
+
+    expect(toJSON()).toMatchSnapshot();
+  });
 });
diff --git a/src/screens/__tests__/__snapshots__/QuizzScreen.test.js.snap b/src/screens/__tests__/__snapshots__/QuizzScreen.test.js.snap
@@ -1435,3 +1435,25 @@ exports[`<QuizzScreen /> renders correctly 3`] = `
   </View>
 </RCTScrollView>
 `;
+
+exports[`<QuizzScreen /> renders correctly with no questions 1`] = `
+<RCTScrollView
+  contentContainerStyle={
+    {
+      "paddingBottom": 64,
+    }
+  }
+  style={
+    {
+      "flex": 1,
+      "padding": 16,
+    }
+  }
+>
+  <View>
+    <Text>
+      We have no question matching your criteria.
+    </Text>
+  </View>
+</RCTScrollView>
+`;
diff --git a/src/utils/locales/en.js b/src/utils/locales/en.js
@@ -98,6 +98,7 @@ export default {
       one: '{{count}} correct answer',
       other: '{{count}} correct answers',
     },
+    noQuestions: 'We have no question matching your criteria.',
     nextQuestion: 'Next question',
   },
   rulesScreen: {

diff --git a/src/utils/locales/fr.js b/src/utils/locales/fr.js
@@ -98,6 +98,7 @@ export default {
       one: '{{count}} bonne réponse',
       other: '{{count}} bonnes réponses',
     },
+    noQuestions: 'Aucune question ne correspond aux critères choisis.',
     nextQuestion: 'Question suivante',
   },
   rulesScreen: {